On Tue, May 04, 2021 at 09:46:35PM +0300, Dan Carpenter wrote:
Hi,
I ran Smatch on 5.4.116 and I found that we were missing commit bb14dd1564c9 ("scsi: ufs: Unlock on a couple error paths").
The problem was caused because somehow my Fixes tag did not match the upstream commit that stable used. I have both hashes in my git tree and the patches are identical except for the hash. I don't know git well enough to say what went wrong. I don't think the SCSI tree rebases?
My fixes tag: Fixes: a276c19e3e98 ("scsi: ufs: Avoid busy-waiting by eliminating tag conflicts") ^^^^^^^^^^^^
Stable hash: commit a8d2d45c70c7391386baf7863674f156da56a3d5 Author: Bart Van Assche bvanassche@acm.org Date: Mon Dec 9 10:13:08 2019 -0800
scsi: ufs: Avoid busy-waiting by eliminating tag conflicts [ Upstream commit 7252a3603015f1fd04363956f4b72a537c9f9c42 ] ^^^^^^^^^^^^regards, dan carpenter
Thanks for catching this, now queued up.
greg k-h