From: Guillaume La Roque glaroque@baylibre.com
[ Upstream commit fcddcb7e8f38a40db99f87a962c5d0a153a76566 ]
Select PM_GENERIC_DOMAINS instead of depending on it to ensure it is always enabled when TI_SCI_PM_DOMAINS is selected. Since PM_GENERIC_DOMAINS is an implicit symbol, it can only be enabled through 'select' and cannot be explicitly enabled in configuration. This simplifies the dependency chain and prevents build issues
Signed-off-by: Guillaume La Roque glaroque@baylibre.com Reviewed-by: Nishanth Menon nm@ti.com Link: https://lore.kernel.org/r/20250715-depspmdomain-v2-1-6f0eda3ce824@baylibre.c... Signed-off-by: Ulf Hansson ulf.hansson@linaro.org Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
Let me analyze based on what I can see from the provided diff:
**Backport Status: YES**
This commit should be backported to stable kernel trees for the following reasons:
1. **Fixes a build configuration issue**: The commit message explicitly states this change "prevents build issues". The problem is that PM_GENERIC_DOMAINS is an implicit symbol that cannot be explicitly enabled by users in configuration menus. Using "depends on" creates a circular dependency problem where users cannot enable TI_SCI_PM_DOMAINS because they cannot manually enable PM_GENERIC_DOMAINS.
2. **Small and contained fix**: The change is minimal - it only modifies one line in a Kconfig file, changing from `depends on PM_GENERIC_DOMAINS` to `select PM_GENERIC_DOMAINS if PM`. This is a low-risk change that only affects the configuration system.
3. **Follows established patterns**: The code shows that other subsystems handle PM_GENERIC_DOMAINS the same way. From my search results, I can see that drivers like QCOM_GDSC, AMD GPU drivers, and others use `select PM_GENERIC_DOMAINS if PM` rather than `depends on PM_GENERIC_DOMAINS`.
4. **Prevents user-facing issues**: Without this fix, users trying to enable TI_SCI_PM_DOMAINS would face a confusing situation where the option might not be available in menuconfig because they cannot satisfy the dependency on PM_GENERIC_DOMAINS (since it's an implicit symbol).
5. **No architectural changes**: This is purely a Kconfig dependency fix that doesn't change any runtime behavior or introduce new features. It only fixes the configuration logic.
6. **Platform-specific fix**: This only affects TI SoC configurations and has no impact on other architectures or subsystems, minimizing the risk of regression.
The commit follows stable tree rules by fixing an important configuration/build issue with minimal risk and no new features or architectural changes.
drivers/pmdomain/ti/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig index 67c608bf7ed0..5386b362a7ab 100644 --- a/drivers/pmdomain/ti/Kconfig +++ b/drivers/pmdomain/ti/Kconfig @@ -10,7 +10,7 @@ if SOC_TI config TI_SCI_PM_DOMAINS tristate "TI SCI PM Domains Driver" depends on TI_SCI_PROTOCOL - depends on PM_GENERIC_DOMAINS + select PM_GENERIC_DOMAINS if PM help Generic power domain implementation for TI device implementing the TI SCI protocol.