Re: Commit 024aa8732acb for 5.4.y

On Fri, Mar 27, 2020 at 02:11:46PM +0100, Rafael J. Wysocki wrote:

Hi Greg at al,

Please the following commit:

commit 024aa8732acb7d2503eae43c3fe3504d0a8646d0 Author: Rafael J. Wysocki rafael.j.wysocki@intel.com Date: Thu Nov 28 23:50:40 2019 +0100

ACPI: PM: s2idle: Rework ACPI events synchronization

Note that the EC GPE processing need not be synchronized in
acpi_s2idle_wake() after invoking acpi_ec_dispatch_gpe(), because
that function checks the GPE status and dispatches its handler if
need be and the SCI action handler is not going to run anyway at
that point.

Moreover, it is better to drain all of the pending ACPI events
before restoring the working-state configuration of GPEs in
acpi_s2idle_restore(), because those events are likely to be related
to system wakeup, in which case they will not be relevant going
forward.

Rework the code to take these observations into account.

Tested-by: Kenneth R. Crudup <kenny@panix.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

into 5.4.y as it is needed to fix an ACPI wakeup events synchronization issue in suspend-to-idle.

Note that this commit was present in 5.5.0, so 5.4.y is the only -stable series needing this fix.

Now queued up, thanks!

greg k-h