-----Original Message----- From: Wei Fang wei.fang@nxp.com Sent: Friday, February 21, 2025 3:42 AM To: Vladimir Oltean vladimir.oltean@nxp.com Cc: Claudiu Manoil claudiu.manoil@nxp.com; Clark Wang xiaoning.wang@nxp.com; andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Ioana Ciornei ioana.ciornei@nxp.com; Y.B. Lu yangbo.lu@nxp.com; michal.swiatkowski@linux.intel.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; imx@lists.linux.dev; stable@vger.kernel.org Subject: RE: [PATCH v2 net 2/9] net: enetc: correct the tx_swbd statistics
I'm not sure "correct the statistics" is the best way to describe this change. Maybe "keep track of correct TXBD count in enetc_map_tx_tso_buffs()"?
Hi Vladimir,
Inspired by Michal, I think we don't need to keep the count variable, because we already have index "i", we just need to record the value of the initial i at the beginning. So I plan to do this optimization on the net-next tree in the future. So I don't think it is necessary to modify enetc_map_tx_tso_hdr().
And what if 'i' wraps around at least one time and becomes greater than the initial 'i'? Instead of 'count' you would have to record the number of wraps. Even if not possible now in specific cases, there should be no limitation on whether 'i' can wrap around in the loop or not (i.e. maybe some users want to try very small Tx rings etc.)