On 9/1/2020 3:01 PM, Sagi Grimberg wrote:
But you also return back &ctrl->ctrl, that is another dereference, and what will make ctrl to be an ERR_PTR?
Anyway, we should probably come up with something more robust...
ok
not sure what you are asking. if it's how long to fail the creation of a new association - it's at least 60s (an admin command timeout).
That's the worst case (admin command timeout), but is it the most common case?
Yes - as it currently corresponds to packet drops. command failures are rare. FC has a feature to speed this up but it's not widely implemented yet.
Would making the timeouts shorter in the initial connect make sense? Just throwing out ideas...
I'd enjoy a reduced time regardless. But the main concern is how long we have the systemd processes blocked.
-- james