From: George Gaidarov gdgaidarov+lkml@gmail.com
[ Upstream commit 493f9c930e5ff72b3508755b45488d1ae2c9650e ]
Device ID '0xa740' is shared by i7-14700, i7-14700K, and i7-14700T. Device ID '0xa704' is shared by i5-14600, i5-14600K, and i5-14600T.
Tested locally on my i7-14700K.
Signed-off-by: George Gaidarov gdgaidarov+lkml@gmail.com Reviewed-by: Qiuxu Zhuo qiuxu.zhuo@intel.com Signed-off-by: Tony Luck tony.luck@intel.com Signed-off-by: Borislav Petkov (AMD) bp@alien8.de Link: https://lore.kernel.org/r/20250529162933.1228735-1-gdgaidarov+lkml@gmail.com Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
**Backport Status: YES**
This commit should be backported to stable kernel trees for the following reasons:
1. **Device ID Addition Only**: This commit adds exactly two new PCI device IDs (`0xa740` and `0xa704`) to enable EDAC (Error Detection and Correction) support for Intel Core i5-14600 and i7-14700 processors. According to the stable kernel rules at Documentation/process/stable-kernel-rules.rst:15, patches that "just add a device ID" are explicitly allowed in stable trees.
2. **Minimal and Safe Change**: The patch is extremely small (4 lines of actual code change), adding only: - Two `#define` statements for the new device IDs - Two entries to the `ie31200_pci_tbl[]` array that map these IDs to the existing `rpl_s_cfg` configuration
3. **No Functional Changes**: The commit doesn't introduce any new functionality, algorithms, or modify existing behavior. It simply extends hardware support using the already-tested Raptor Lake-S configuration (`rpl_s_cfg`) for these new processor variants.
4. **Tested Hardware**: The commit message indicates "Tested locally on my i7-14700K", showing the change has been verified on actual hardware.
5. **Pattern of Similar Commits**: Looking at the driver's history, similar hardware enablement commits have been regularly added (e.g., commits `180f091224a0`, `021681830e41`, `05a61c6cb631`), following the same pattern of adding device IDs for new processor variants.
6. **User Benefit**: Without this patch, users with these specific Intel processors cannot use EDAC functionality to detect and report memory errors, which is an important reliability feature for systems using ECC memory.
The commit perfectly fits the stable tree criteria of being a simple device ID addition that enables existing, tested functionality for new hardware variants without any risk of regression to existing systems.
drivers/edac/ie31200_edac.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c index a53612be4b2f..6aac6672ba38 100644 --- a/drivers/edac/ie31200_edac.c +++ b/drivers/edac/ie31200_edac.c @@ -91,6 +91,8 @@ #define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_2 0x4640 #define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_3 0x4630 #define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_4 0xa700 +#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_5 0xa740 +#define PCI_DEVICE_ID_INTEL_IE31200_RPL_S_6 0xa704
/* Alder Lake-S */ #define PCI_DEVICE_ID_INTEL_IE31200_ADL_S_1 0x4660 @@ -740,6 +742,8 @@ static const struct pci_device_id ie31200_pci_tbl[] = { { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_2), (kernel_ulong_t)&rpl_s_cfg}, { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_3), (kernel_ulong_t)&rpl_s_cfg}, { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_4), (kernel_ulong_t)&rpl_s_cfg}, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_5), (kernel_ulong_t)&rpl_s_cfg}, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_RPL_S_6), (kernel_ulong_t)&rpl_s_cfg}, { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IE31200_ADL_S_1), (kernel_ulong_t)&rpl_s_cfg}, { 0, } /* 0 terminated list. */ };