On 10/6/24 18:18, Sasha Levin wrote:
This is a note to let you know that I've just added the patch titled
ata: pata_serverworks: Do not use the term blacklistto the 6.11-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: ata-pata_serverworks-do-not-use-the-term-blacklist.patch and it can be found in the queue-6.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
Hm... again, what exactly does this commit fix? :-/
commit 106fce3509096c391ee57d0482d1e857e3dfb6fb Author: Damien Le Moal dlemoal@kernel.org Date: Fri Jul 26 10:58:36 2024 +0900
ata: pata_serverworks: Do not use the term blacklist[ Upstream commit 858048568c9e3887d8b19e101ee72f129d65cb15 ] Let's not use the term blacklist in the function serverworks_osb4_filter() documentation comment and rather simply refer to what that function looks at: the list of devices with groken UDMA5. While at it, also constify the values of the csb_bad_ata100 array. Of note is that all of this should probably be handled using libata quirk mechanism but it is unclear if these UDMA5 quirks are specific to this controller only. Signed-off-by: Damien Le Moal dlemoal@kernel.org Reviewed-by: Niklas Cassel cassel@kernel.org Reviewed-by: Igor Pylypiv ipylypiv@google.com Signed-off-by: Sasha Levin sashal@kernel.org
diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c index 549ff24a98231..4edddf6bcc150 100644 --- a/drivers/ata/pata_serverworks.c +++ b/drivers/ata/pata_serverworks.c @@ -46,10 +46,11 @@ #define SVWKS_CSB5_REVISION_NEW 0x92 /* min PCI_REVISION_ID for UDMA5 (A2.0) */ #define SVWKS_CSB6_REVISION 0xa0 /* min PCI_REVISION_ID for UDMA4 (A1.0) */ -/* Seagate Barracuda ATA IV Family drives in UDMA mode 5
- can overrun their FIFOs when used with the CSB5 */
-static const char *csb_bad_ata100[] = { +/*
- Seagate Barracuda ATA IV Family drives in UDMA mode 5
- can overrun their FIFOs when used with the CSB5.
- */
+static const char * const csb_bad_ata100[] = { "ST320011A", "ST340016A", "ST360021A", @@ -163,10 +164,11 @@ static unsigned int serverworks_osb4_filter(struct ata_device *adev, unsigned in
- @adev: ATA device
- @mask: Mask of proposed modes
- Check the blacklist and disable UDMA5 if matched
- Check the list of devices with broken UDMA5 and
*/
- disable UDMA5 if matched.
-static unsigned int serverworks_csb_filter(struct ata_device *adev, unsigned int mask) +static unsigned int serverworks_csb_filter(struct ata_device *adev,
unsigned int mask){ const char *p; char model_num[ATA_ID_PROD_LEN + 1];
MBR, Sergey