2018-06-19 15:52 GMT+02:00 Lukas Wunner lukas@wunner.de:
On Tue, Jun 19, 2018 at 02:44:00PM +0200, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski bgolaszewski@baylibre.com
This patch reverts commit 3243ff2a05ec ("net: ethernet: davinci_emac: Deduplicate bus_find_device() by name matching") and adds a comment which should stop anyone from reintroducing the same "fix" in the future.
We can't use bus_find_device_by_name() here because the device name is not guaranteed to be 'davinci_mdio'. On some systems it can be 'davinci_mdio.0' so we need to use strncmp() against the first part of the string to correctly match it.
Fixes: 3243ff2a05ec ("net: ethernet: davinci_emac: Deduplicate bus_find_device() by name matching") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski bgolaszewski@baylibre.com
Acked-by: Lukas Wunner lukas@wunner.de
My apologies Bartosz, it wasn't clear to me that the driver deliberately only matched against the prefix of the name. Sorry for the breakage.
No issue. I submitted a follow-up series with additional changes required to make suspend/resume work. Please leave your Acked-by there as well as I forgot to pick it up.
Thanks in advance, Bartosz Golaszewski