29 Nov
2018
29 Nov
'18
12:18 p.m.
On Thu, Nov 29, 2018 at 04:20:01PM +0800, Aaron Ma wrote:
commit 958c0bd86075d4ef1c936998deefe1947e539240 upstream.
Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3, after clear port reset it works fine.
Since this device is registered on USB3 roothub at boot, when port status reports not superspeed, xhci_get_port_status will call an uninitialized completion in bus_state[0]. Kernel will hang because of NULL pointer.
Restrict the USB2 resume status check in USB2 roothub to fix hang issue.
Cc: stable@vger.kernel.org # 4.17.x-
Didn't work on 4.14.y, but I fixed it up there by hand...
thanks,
greg k-h