27 Jun
2023
27 Jun
'23
1:40 p.m.
Hi Andrew,
On Tue, Jun 27, 2023 at 3:07 PM Andrew Lunn andrew@lunn.ch wrote:
+static int lan743x_csr_wait_for_bit_atomic(struct lan743x_adapter *adapter,
adapter is not used in readx_poll_timeout_atomic() call, right? can be removed.
I thought that when i first looked at an earlier version of this patch. But LAN743X_CSR_READ_OP is not what you think :-(
Yeah, it's not great / confusing. I tried to keep it the same as the rest of the file when fixing the bug.
I can see if I can clean it up across the file in a follow up.
Andrew
Do you want me to send a v4 with an updated commit message?
Thanks, Moritz