On Fri, Sep 07, 2018 at 04:43:46PM +0800, Chunfeng Yun wrote:
Hi,
On Fri, 2018-09-07 at 09:42 +0200, Greg Kroah-Hartman wrote:
On Fri, Sep 07, 2018 at 03:29:12PM +0800, Chunfeng Yun wrote:
The MTK xHCI controller use some reserved bytes in endpoint context for bandwidth scheduling, so need keep them in xhci_endpoint_copy();
If they are "reserved" shouldn't they be properly named? And by using reserved bytes, isn't that a spec violation?
It indeed violates the spec, "they shall be treated by system software as Reserved and Opaque", and it's a quirk of the MTK xHCI controller.
So as the "system software" here, we should just ignore them otherwise we violate the spec? :)
Anyway, that's fine, no objection from me for the patch, thanks.
greg k-h