On Wed, Mar 13, 2024 at 04:23:04PM +0200, Adrian Hunter wrote:
On 13/03/24 15:37, mikko.rapeli@linaro.org wrote:
From: Mikko Rapeli mikko.rapeli@linaro.org
Commit "mmc: core: Use mrq.sbc in close-ended ffu" adds flags uint to struct mmc_blk_ioc_data but it does not get initialized for RPMB ioctls which now fail.
Fix this by always initializing the struct and flags to zero.
Fixes access to RPMB storage.
Fixes: 4d0c8d0aef63 ("mmc: core: Use mrq.sbc in close-ended ffu")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218587
Link: https://lore.kernel.org/all/20231129092535.3278-1-avri.altman@wdc.com/
Cc: Avri Altman avri.altman@wdc.com Cc: Ulf Hansson ulf.hansson@linaro.org Cc: Adrian Hunter adrian.hunter@intel.com Cc: linux-mmc@vger.kernel.org Cc: stable@vger.kernel.org Signed-off-by: Mikko Rapeli mikko.rapeli@linaro.org
Not used to seeing blank lines after Fixes:, Closes, Link: tags, nevertheless:
From what I know no spaces in between the tags at the end of the commit message is just required. Having empty line there might break some tooling and automation.
Acked-by: Adrian Hunter adrian.hunter@intel.com
Tested-by: Francesco Dolcini francesco.dolcini@toradex.com
Ulf, Adrian: the bug these 2 patches are fixing is now in LTS kernel, it would be beneficial to have the fix in mainline ASAP.
Francesco