On Fri, Mar 29, 2024 at 11:17 AM Mimi Zohar zohar@linux.ibm.com wrote:
On Fri, 2024-03-29 at 11:56 +0100, Roberto Sassu wrote:
From: Roberto Sassu roberto.sassu@huawei.com
Rename ima_post_path_mknod() and evm_post_path_mknod() respectively to ima_path_post_mknod() and evm_path_post_mknod(), to facilitate finding users of the path_post_mknod LSM hook.
Cc: stable@vger.kernel.org # 6.8.x
Since commit cd3cec0a02c7 ("ima: Move to LSM infrastructure") was upstreamed in this open window. This change does not need to be packported and should be limited to IMA and EVM full fledge LSMs.
Reported-by: Christian Brauner christian@brauner.io Closes: https://lore.kernel.org/linux-kernel/20240328-raushalten-krass-cb040068bde9@... Fixes: 05d1a717ec04 ("ima: add support for creating files using the mknodat syscall")
"Fixes: 05d1a717ec04" should be removed.
I'd take it one step further and remove both 'Fixes' tags. A 'Fixes' tag implies a flaw in the functionality of the code, this is just a function rename.
Another important thing to keep in mind about 'Fixes' tags, unless you've told the stable kernel folks to only take patches that you've explicitly marked for stable, they are likely going to attempt to backport anything with a 'Fixes' tag.
Regardless, since I was looking at 1/2 I took a quick look at this patch and it looks fine to me once the comments have been incorporated.
Reviewed-by: Paul Moore paul@paul-moore.com
Fixes: cd3cec0a02c7 ("ima: Move to LSM infrastructure") Signed-off-by: Roberto Sassu roberto.sassu@huawei.com
Acked-by: Mimi Zohar zohar@linux.ibm.com