On Wed, Feb 16, 2022 at 07:31:37AM +0100, Oliver Hartkopp wrote:
Upstream commit 921ca574cd382142add8b12d0a7117f495510de5
The patch was intended for 5.10 but missed the merge window by some days. This missing patch continously breaks the backport of stable fixes and is the only missing feature of upstream isotp in Linux 5.10 e.g. for RasPi.
When CAN_ISOTP_SF_BROADCAST is set in the CAN_ISOTP_OPTS flags the CAN_ISOTP socket is switched into functional addressing mode, where only single frame (SF) protocol data units can be send on the specified CAN interface and the given tp.tx_id after bind().
In opposite to normal and extended addressing this socket does not register a CAN-ID for reception which would be needed for a 1-to-1 ISOTP connection with a segmented bi-directional data transfer.
Sending SFs on this socket is therefore a TX-only 'broadcast' operation.
Signed-off-by: Oliver Hartkopp socketcan@hartkopp.net Signed-off-by: Thomas Wagner thwa1@web.de Link: https://lore.kernel.org/r/20201206144731.4609-1-socketcan@hartkopp.net Signed-off-by: Marc Kleine-Budde mkl@pengutronix.de
include/uapi/linux/can/isotp.h | 2 +- net/can/isotp.c | 50 ++++++++++++++++++++++++---------- 2 files changed, 37 insertions(+), 15 deletions(-)
Both now queued up, thanks.
greg k-h