[PATCH 5.15 118/171] i40e: Fix failed opcode appearing if handling messages from VF

13 Dec 2021

From: Karen Sornek karen.sornek@intel.com
commit 61125b8be85dfbc7e9c7fe1cc6c6d631ab603516 upstream.
Fix failed operation code appearing if handling messages from VF.
Implemented by waiting for VF appropriate state if request starts
handle while VF reset.
Without this patch the message handling request while VF is in
a reset state ends with error -5 (I40E_ERR_PARAM).
Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface")
Signed-off-by: Grzegorz Szczurek grzegorzx.szczurek@intel.com
Signed-off-by: Karen Sornek karen.sornek@intel.com
Tested-by: Tony Brelinski tony.brelinski@intel.com
Signed-off-by: Tony Nguyen anthony.l.nguyen@intel.com
Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |   70 ++++++++++++++-------
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h |    2 
 2 files changed, 50 insertions(+), 22 deletions(-)

--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -1949,6 +1949,32 @@ static int i40e_vc_send_resp_to_vf(struc
 }
/**
+ * i40e_sync_vf_state
+ * @vf: pointer to the VF info
+ * @state: VF state
+ *
+ * Called from a VF message to synchronize the service with a potential
+ * VF reset state
+ **/
+static bool i40e_sync_vf_state(struct i40e_vf *vf, enum i40e_vf_states state)
+{
+	int i;
+
+	/* When handling some messages, it needs VF state to be set.
+	 * It is possible that this flag is cleared during VF reset,
+	 * so there is a need to wait until the end of the reset to
+	 * handle the request message correctly.
+	 */
+	for (i = 0; i < I40E_VF_STATE_WAIT_COUNT; i++) {
+		if (test_bit(state, &vf->vf_states))
+			return true;
+		usleep_range(10000, 20000);
+	}
+
+	return test_bit(state, &vf->vf_states);
+}
+
+/**
  * i40e_vc_get_version_msg
  * @vf: pointer to the VF info
  * @msg: pointer to the msg buffer
@@ -2008,7 +2034,7 @@ static int i40e_vc_get_vf_resources_msg(
    size_t len = 0;
    int ret;
-	if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_INIT)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -2131,7 +2157,7 @@ static int i40e_vc_config_promiscuous_mo
    bool allmulti = false;
    bool alluni = false;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err_out;
    }
@@ -2219,7 +2245,7 @@ static int i40e_vc_config_queues_msg(str
    struct i40e_vsi *vsi;
    u16 num_qps_all = 0;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto error_param;
    }
@@ -2368,7 +2394,7 @@ static int i40e_vc_config_irq_map_msg(st
    i40e_status aq_ret = 0;
    int i;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto error_param;
    }
@@ -2540,7 +2566,7 @@ static int i40e_vc_disable_queues_msg(st
    struct i40e_pf *pf = vf->pf;
    i40e_status aq_ret = 0;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto error_param;
    }
@@ -2590,7 +2616,7 @@ static int i40e_vc_request_queues_msg(st
    u8 cur_pairs = vf->num_queue_pairs;
    struct i40e_pf *pf = vf->pf;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states))
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE))
    	return -EINVAL;
if (req_pairs > I40E_MAX_VF_QUEUES) {
@@ -2635,7 +2661,7 @@ static int i40e_vc_get_stats_msg(struct
memset(&stats, 0, sizeof(struct i40e_eth_stats));
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto error_param;
    }
@@ -2752,7 +2778,7 @@ static int i40e_vc_add_mac_addr_msg(stru
    i40e_status ret = 0;
    int i;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states) ||
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE) ||
        !i40e_vc_isvalid_vsi_id(vf, al->vsi_id)) {
    	ret = I40E_ERR_PARAM;
    	goto error_param;
@@ -2824,7 +2850,7 @@ static int i40e_vc_del_mac_addr_msg(stru
    i40e_status ret = 0;
    int i;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states) ||
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE) ||
        !i40e_vc_isvalid_vsi_id(vf, al->vsi_id)) {
    	ret = I40E_ERR_PARAM;
    	goto error_param;
@@ -2968,7 +2994,7 @@ static int i40e_vc_remove_vlan_msg(struc
    i40e_status aq_ret = 0;
    int i;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states) ||
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE) ||
        !i40e_vc_isvalid_vsi_id(vf, vfl->vsi_id)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto error_param;
@@ -3088,9 +3114,9 @@ static int i40e_vc_config_rss_key(struct
    struct i40e_vsi *vsi = NULL;
    i40e_status aq_ret = 0;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states) ||
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE) ||
        !i40e_vc_isvalid_vsi_id(vf, vrk->vsi_id) ||
-	    (vrk->key_len != I40E_HKEY_ARRAY_SIZE)) {
+	    vrk->key_len != I40E_HKEY_ARRAY_SIZE) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3119,9 +3145,9 @@ static int i40e_vc_config_rss_lut(struct
    i40e_status aq_ret = 0;
    u16 i;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states) ||
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE) ||
        !i40e_vc_isvalid_vsi_id(vf, vrl->vsi_id) ||
-	    (vrl->lut_entries != I40E_VF_HLUT_ARRAY_SIZE)) {
+	    vrl->lut_entries != I40E_VF_HLUT_ARRAY_SIZE) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3154,7 +3180,7 @@ static int i40e_vc_get_rss_hena(struct i
    i40e_status aq_ret = 0;
    int len = 0;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3190,7 +3216,7 @@ static int i40e_vc_set_rss_hena(struct i
    struct i40e_hw *hw = &pf->hw;
    i40e_status aq_ret = 0;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3215,7 +3241,7 @@ static int i40e_vc_enable_vlan_stripping
    i40e_status aq_ret = 0;
    struct i40e_vsi *vsi;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3241,7 +3267,7 @@ static int i40e_vc_disable_vlan_strippin
    i40e_status aq_ret = 0;
    struct i40e_vsi *vsi;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3468,7 +3494,7 @@ static int i40e_vc_del_cloud_filter(stru
    i40e_status aq_ret = 0;
    int i, ret;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3599,7 +3625,7 @@ static int i40e_vc_add_cloud_filter(stru
    i40e_status aq_ret = 0;
    int i, ret;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err_out;
    }
@@ -3708,7 +3734,7 @@ static int i40e_vc_add_qch_msg(struct i4
    i40e_status aq_ret = 0;
    u64 speed = 0;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
@@ -3824,7 +3850,7 @@ static int i40e_vc_del_qch_msg(struct i4
    struct i40e_pf *pf = vf->pf;
    i40e_status aq_ret = 0;
-	if (!test_bit(I40E_VF_STATE_ACTIVE, &vf->vf_states)) {
+	if (!i40e_sync_vf_state(vf, I40E_VF_STATE_ACTIVE)) {
    	aq_ret = I40E_ERR_PARAM;
    	goto err;
    }
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h
@@ -18,6 +18,8 @@
#define I40E_MAX_VF_PROMISC_FLAGS	3
+#define I40E_VF_STATE_WAIT_COUNT	20
+
 /* Various queue ctrls */
 enum i40e_queue_ctrl {
    I40E_QUEUE_CTRL_UNKNOWN = 0,

    

2025

2024

2023

2022

2021

2020

2019

2018

2017

[PATCH 5.15 118/171] i40e: Fix failed opcode appearing if handling messages from VF