Re: [PATCH v6 1/4] lib/pci_iomap.c: fix cleanup bug in pci_iounmap()

On Wed, Jan 31, 2024 at 10:00:20AM +0100, Philipp Stanner wrote:

The #ifdef for the ioport-ranges accidentally also guards iounmap(), potentially compiling an empty function. This would cause the mapping to be leaked.

Move the guard so that iounmap() will always be part of the function.

I tweaked the subject and commit log to be more explicit about what the bug is. Let me know if I got it wrong:

pci_iounmap(): Fix MMIO mapping leak

The #ifdef ARCH_HAS_GENERIC_IOPORT_MAP accidentally also guards iounmap(), which means MMIO mappings are leaked.

Move the guard so we call iounmap() for MMIO mappings.

Bjorn