Re: [PATCH v2] target: fix truncated PR-in ReadKeys response

• if ((off + 8) <= cmd->data_length) {
  

No need for the inner braces.

• 	put_unaligned_be64(pr_reg->pr_res_key, &buf[off]);
  

• 	off += 8;
  

• }
  

• /*
  

•  * SPC5r17: 6.16.2 READ KEYS service action
  

•  * The ADDITIONAL LENGTH field indicates the number of bytes in
  

•  * the Reservation key list. The contents of the ADDITIONAL
  

•  * LENGTH field are not altered based on the allocation length
  

•  */
  

  add_len += 8; } spin_unlock(&dev->t10_pr.registration_lock);

Otherwise looks fine:

Reviewed-by: Christoph Hellwig hch@lst.de