Re: [PATCH] PCI: j721e: Set .map_irq and .swizzle_irq to NULL

On Wed, Jul 24, 2024 at 09:49:21PM +0530, Manivannan Sadhasivam wrote:

On Wed, Jul 24, 2024 at 12:20:48PM +0530, Siddharth Vadapalli wrote:

...

Since the configuration of Legacy Interrupts (INTx) is not supported, set the .map_irq and .swizzle_irq callbacks to NULL. This fixes the error: of_irq_parse_pci: failed with rc=-22 due to the absence of Legacy Interrupts in the device-tree.

Do you really need to set 'swizzle_irq' to NULL? pci_assign_irq() will bail out if 'map_irq' is set to NULL.

Hold on. The errono of of_irq_parse_pci() is not -ENOENT. So the INTx interrupts are described in DT? Then why are they not supported?

- Mani