-----Original Message----- From: Intel-wired-lan intel-wired-lan-bounces@osuosl.org On Behalf Of Simon Horman Sent: Friday, July 26, 2024 9:16 AM To: Lobakin, Aleksander aleksander.lobakin@intel.com Cc: Linga, Pavan Kumar pavan.kumar.linga@intel.com; NEX SW NCIS OSDT ITP Upstreaming nex.sw.ncis.osdt.itp.upstreaming@intel.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; stable@vger.kernel.org; Eric Dumazet edumazet@google.com; Kubiak, Michal michal.kubiak@intel.com; Nguyen, Anthony L anthony.l.nguyen@intel.com; Jakub Kicinski kuba@kernel.org; intel-wired- lan@lists.osuosl.org; Paolo Abeni pabeni@redhat.com; David S. Miller davem@davemloft.net Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/3] idpf: fix memleak in vport interrupt configuration
On Wed, Jul 24, 2024 at 03:40:23PM +0200, Alexander Lobakin wrote:
From: Michal Kubiak michal.kubiak@intel.com
The initialization of vport interrupt consists of two functions:
- idpf_vport_intr_init() where a generic configuration is done
- idpf_vport_intr_req_irq() where the irq for each q_vector is
requested.
The first function used to create a base name for each interrupt using "kasprintf()" call. Unfortunately, although that call allocated memory for a text buffer, that memory was never released.
Fix this by removing creating the interrupt base name in 1). Instead, always create a full interrupt name in the function 2), because there is no need to create a base name separately, considering that the function 2) is never called out of idpf_vport_intr_init() context.
Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Michal Kubiak michal.kubiak@intel.com Reviewed-by: Pavan Kumar Linga pavan.kumar.linga@intel.com Signed-off-by: Alexander Lobakin aleksander.lobakin@intel.com
Reviewed-by: Simon Horman horms@kernel.org
Tested-by: Krishneil Singh krishneil.k.singh@intel.com