From: Jackie Liu liuyun01@kylinos.cn
[ Upstream commit 42147981561c3344d2c6781fe7029e5900daa9fb ]
Jump directly to done_kfree to release d, which is consistent with the code style behind.
Reported-by: Genjian Zhang zhanggenjian@kylinos.cn Signed-off-by: Jackie Liu liuyun01@kylinos.cn Reviewed-by: Sagi Grimberg sagi@grimberg.me Reviewed-by: Chaitanya Kulkarni kch@nvidia.com Reviewed-by: Hannes Reinecke hare@suse.de Signed-off-by: Christoph Hellwig hch@lst.de Signed-off-by: Sasha Levin sashal@kernel.org --- drivers/nvme/target/fabrics-cmd-auth.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/fabrics-cmd-auth.c index ebdf9aa81041..8458ec40340b 100644 --- a/drivers/nvme/target/fabrics-cmd-auth.c +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -229,10 +229,8 @@ void nvmet_execute_auth_send(struct nvmet_req *req) }
status = nvmet_copy_from_sgl(req, 0, d, tl); - if (status) { - kfree(d); - goto done; - } + if (status) + goto done_kfree;
data = d; pr_debug("%s: ctrl %d qid %d type %d id %d step %x\n", __func__,