On Mon, Oct 21, 2024 at 10:08 AM Tomi Valkeinen tomi.valkeinen@ideasonboard.com wrote:
From: Devarsh Thakkar devarsht@ti.com
The driver does not touch the irqstatus register when it is disabling interrupts. This might cause an interrupt to trigger for an interrupt that was just disabled.
To fix the issue, clear the irqstatus registers right after disabling the interrupts.
Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display SubSystem") Cc: stable@vger.kernel.org Reported-by: Jonathan Cormier jcormier@criticallink.com Closes: https://e2e.ti.com/support/processors-group/processors/f/processors-forum/13... Signed-off-by: Devarsh Thakkar devarsht@ti.com [Tomi: mostly rewrote the patch] Signed-off-by: Tomi Valkeinen tomi.valkeinen@ideasonboard.com
Thanks for the updates. They look pretty similar to the changes I proposed and thus look good to me. Reviewed-by: Jonathan Cormier jcormier@criticallink.com Tested an equivalent patch for several weeks. Tested-by: Jonathan Cormier jcormier@criticallink.com
drivers/gpu/drm/tidss/tidss_dispc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c index 99a1138f3e69..515f82e8a0a5 100644 --- a/drivers/gpu/drm/tidss/tidss_dispc.c +++ b/drivers/gpu/drm/tidss/tidss_dispc.c