Re: [PATCH v6 3/7] dt-bindings: mmc: tegra: Add tmclk for Tegra210 and later

On 27/08/2020 04:49, Sowjanya Komatineni wrote:

Tegra210 and later uses separate SDMMC_LEGACY_TM clock for data timeout.

So, this patch adds "tmclk" to Tegra sdhci clock property in the device tree binding.

Signed-off-by: Sowjanya Komatineni skomatineni@nvidia.com

.../bindings/mmc/nvidia,tegra20-sdhci.txt | 32 ++++++++++++++++++++-- 1 file changed, 29 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt index 2cf3aff..96c0b14 100644 --- a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt @@ -15,8 +15,15 @@ Required properties:

• "nvidia,tegra210-sdhci": for Tegra210
• "nvidia,tegra186-sdhci": for Tegra186
• "nvidia,tegra194-sdhci": for Tegra194

-- clocks : Must contain one entry, for the module clock.

• See ../clocks/clock-bindings.txt for details.

+- clocks: For Tegra210, Tegra186 and Tegra194 must contain two entries.

•  One for the module clock and one for the timeout clock.
  

•  For all other Tegra devices, must contain a single entry for
  

•  the module clock. See ../clocks/clock-bindings.txt for details.
  

+- clock-names: For Tegra210, Tegra186 and Tegra194 must contain the

•       strings 'sdhci' and 'tmclk' to represent the module and
  

•       the timeout clocks, respectively.
  

•       For all other Tegra devices must contain the string 'sdhci'
  

•       to represent the module clock.
  

• resets : Must contain an entry for each entry in reset-names. See ../reset/reset.txt for details.
• reset-names : Must include the following entries:

@@ -99,7 +106,7 @@ Optional properties for Tegra210, Tegra186 and Tegra194: Example: sdhci@700b0000 {

• compatible = "nvidia,tegra210-sdhci", "nvidia,tegra124-sdhci";

• compatible = "nvidia,tegra124-sdhci"; reg = <0x0 0x700b0000 0x0 0x200>; interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>; clocks = <&tegra_car TEGRA210_CLK_SDMMC1>;

@@ -115,3 +122,22 @@ sdhci@700b0000 { nvidia,pad-autocal-pull-down-offset-1v8 = <0x7b>; status = "disabled"; };

+sdhci@700b0000 {

• compatible = "nvidia,tegra210-sdhci";
• reg = <0x0 0x700b0000 0x0 0x200>;
• interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
• clocks = <&tegra_car TEGRA210_CLK_SDMMC1>,

•  <&tegra_car TEGRA210_CLK_SDMMC_LEGACY>;
  

• clock-names = "sdhci", "tmclk";
• resets = <&tegra_car 14>;
• reset-names = "sdhci";
• pinctrl-names = "sdmmc-3v3", "sdmmc-1v8";
• pinctrl-0 = <&sdmmc1_3v3>;
• pinctrl-1 = <&sdmmc1_1v8>;
• nvidia,pad-autocal-pull-up-offset-3v3 = <0x00>;
• nvidia,pad-autocal-pull-down-offset-3v3 = <0x7d>;
• nvidia,pad-autocal-pull-up-offset-1v8 = <0x7b>;
• nvidia,pad-autocal-pull-down-offset-1v8 = <0x7b>;
• status = "disabled";

+};

Thanks!

Reviewed-by: Jon Hunter jonathanh@nvidia.com

Cheers Jon