On Fri, Apr 23, 2021 at 08:04:57AM +0100, Luca Fancellu wrote:
On 23 Apr 2021, at 08:00, Juergen Gross jgross@suse.com wrote: On 23.04.21 08:55, Luca Fancellu wrote:
On 23 Apr 2021, at 06:40, Juergen Gross jgross@suse.com wrote:
Commit d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert") introduced an error in gntdev_mmap(): in case the call of mmu_interval_notifier_insert_locked() fails the exit path should not call mmu_interval_notifier_remove(), as this might result in NULL dereferences.
One reason for failure is e.g. a signal pending for the running process.
Fixes: d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert") Cc: stable@vger.kernel.org Reported-by: Marek Marczykowski-Górecki marmarek@invisiblethingslab.com Tested-by: Marek Marczykowski-Górecki marmarek@invisiblethingslab.com Signed-off-by: Juergen Gross jgross@suse.com
(...)
Right, thanks, seems good to me.
Reviewed-by: Luca Fancellu luca.fancellu@arm.com
Can somebody ack this fix please?