On 5/12/2023 8:31 AM, Bryan O'Donoghue wrote:
On 04/05/2023 09:00, Konrad Dybcio wrote:
Tested on 8250, but pretty please test it on your boards too!
What's the definition of test here ?
I ran this
ffplay -codec:video h264_v4l2m2m FantasticFour-ROTSS.mp4
and this
ffplay -codec:video vp8_v4l2m2m /mnt/big-buck-bunny_trailer.webm
on db410c with no errors. Then again I applied and disapplied the 8x8 264 fix to that branch and saw no discernable difference so I'm not very confident we have good coverage.
@Stan @Vikash could you give some suggested tests for coverage here ?
I could think of below test aspects for this series 1. Suspend Resume 2. Concurrency test 3. Module load -> video usecase -> module unload -> module load -> video usecase. This would ensure video firmware is reloaded and functional. 4. Video playback and encode for all supported resolution and codecs. 5. In general, video playback with more test content.
I would be testing the series with stability test suite on CrOS. That would be either on sc7180 or sc7280 setup.
Konrad, you can post the new version as one patch needs to be dropped. Test can be done on the new version. There are few patches in the series pending review, which can be done in parallel.
-Vikash
@Konrad - get a db410c !
My superficial first-pass on this series looks good but, before giving a Tested-by here, I think we should define a set of coverage tests, run them - the upper end on sm8250 and lower end msm8916 "makes sense to me"
20? different gstreamer tests at different formats and different sizes on our selected platforms db410c, rb5, rb3 I have - also an 820 I haven't booted and an enforce sdm660.
Which tests will we use to validate this series and subsequent series to ensure we don't have more regressions ?
bod