Re: console: Drop added "static" for newport_con

On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:

Please add this patch to stable 4.14

commit f54450ad1942287cc76b38021c0441fc4901d2de Author: Kees Cook keescook@chromium.org Date: Tue Feb 27 13:11:21 2018 -0800

console: Drop added "static" for newport_con

Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
added "static" to newport_con instance of struct consw, while trying to
normalize the declarations. This, however, needed to stay non-static as it
has an extern.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Why does 4.14.y need it?

It really fixes commit c396a5bf457f ("console: Expand dummy functions for CFI") which only showed up in 4.17-rc1.

Why would 4.14.y need it?

confused,

greg k-h