Re: Patch "driver core: platform: Emit a warning if a remove callback returned non-zero" has been added to the 5.10-stable tree

On Sun, Jun 16, 2024 at 09:32:45AM +0200, Uwe Kleine-König wrote:

Hello Sasha,

On 6/16/24 04:18, Sasha Levin wrote:

...

This is a note to let you know that I've just added the patch titled

 driver core: platform: Emit a warning if a remove callback returned non-zero

to the 5.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...

The filename of the patch is: driver-core-platform-emit-a-warning-if-a-remove-call.patch and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.

commit 2f1ac60bc9668567f021c314312563951039f77b Author: Uwe Kleine-König uwe@kleine-koenig.org Date: Sun Feb 7 22:15:37 2021 +0100

 driver core: platform: Emit a warning if a remove callback returned non-zero
 [ Upstream commit e5e1c209788138f33ca6558bf9f572f6904f486d ]
 The driver core ignores the return value of a bus' remove callback. However
 a driver returning an error code is a hint that there is a problem,
 probably a driver author who expects that returning e.g. -EBUSY has any
 effect.
 The right thing to do would be to make struct platform_driver::remove()
 return void. With the immense number of platform drivers this is however a
 big quest and I hope to prevent at least a few new drivers that return an
 error code here.
 Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
 Link: https://lore.kernel.org/r/20210207211537.19992-1-uwe@kleine-koenig.org
 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 Stable-dep-of: 55c421b36448 ("mmc: davinci: Don't strip remove function when driver is builtin")
 Signed-off-by: Sasha Levin <sashal@kernel.org>

That looks wrong. If this patch should be included in stable, it shouldn't be because it's a dependency. 55c421b36448 works without this patch for sure.

Either backport e5e1c2097881 because you think that warning should be in 5.10.x, or don't backport it.

I've fixed this up by hand and dropped all of the platform patches now, thanks for the review!

greg k-h