Re: [PATCH v2] io_uring: Change res2 parameter type in io_uring_cmd_done

On 12/3/24 10:31, Bernd Schubert wrote:

Change the type of the res2 parameter in io_uring_cmd_done from ssize_t to u64. This aligns the parameter type with io_req_set_cqe32_extra, which expects u64 arguments. The change eliminates potential issues on 32-bit architectures where ssize_t might be 32-bit.

Only user of passing res2 is drivers/nvme/host/ioctl.c and it actually passes u64.

LGTM. We can also convert all parameters to match the ABI, i.e. io_uring_cqe::res is s32, "ssize_t ret" is just truncated.