Re: Regression in v4.4.124 due to 'genirq: Use irqd_get_trigger_type to compare ..'

On Wed, Mar 28, 2018 at 02:59:18PM -0700, Guenter Roeck wrote:

Hi Greg,

commit 9d0273bb1c4b64 ("genirq: Use irqd_get_trigger_type to compare the trigger type for shared IRQs") causes a regression in v4.4.124. The problem has been fixed upstream with commit 4f8413a3a799 ("genirq: Track whether the trigger type has been set"). Please apply that patch to v4.4.y at your earliest convenience.

The patch does not apply cleanly; you'll get a conflict include/linux/irq.h. The fix is simple - just take the version introduced by the patch. It adds a couple of extra defines, but those don't hurt and just keep the code aligned with upstream.

Thanks, this was also needed for 4.9.y and 3.18.y.

greg k-h