On Tue, Jan 18, 2022 at 11:58:53AM -0600, Bjorn Helgaas wrote:
Thanks for writing this down! I do the same for PCI. I suspect this is a pretty conservative style that would be acceptable tree-wide even if not required everywhere.
Yeah, although that is an uphill battle. People do love their personal pronouns in commit messages even if it reads weird. And don't get me wrong - I used to do it too but tglx started with this passive formulation and now I see how it is a lot less intrusive and keeps the focus on the issue at hand.
I don't really care much one way or the other. I think the simplest approach is to remove QFLAG_APPLY_ONCE from intel_graphics_quirks() and do nothing else, as I suggested here:
https://lore.kernel.org/r/20220113000805.GA295089@bhelgaas
Unfortunately that didn't occur to me until I'd already suggested more complicated things that no longer seem worthwhile to me.
The static variable might be ugly, but it does seem to be what intel_graphics_quirks() wants -- a "do this at most once per system but we don't know exactly which device" situation.
I see.
Yeah, keeping it solely inside intel_graphics_quirks() and maybe with a comment ontop, why it is done, is simple. I guess if more quirks need this once-thing people might have to consider a more sensible scheme - I was just objecting to sprinkling those static vars everywhere.
But your call. :)
Thx.