On 5/3/2024 6:16 PM, Krzysztof Kozlowski wrote:
On 02/05/2024 16:06, Zijun Hu wrote:
Commit 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed serdev") will cause below regression issue:
BT can't be enabled after below steps: cold boot -> enable BT -> disable BT -> warm reboot -> BT enable failure if property enable-gpios is not configured within DT|ACPI for QCA6390.
The commit is to fix a use-after-free issue within qca_serdev_shutdown() during reboot, but also introduces this regression issue regarding above steps since the VSC is not sent to reset controller during warm reboot.
Fixed by sending the VSC to reset controller within qca_serdev_shutdown() once BT was ever enabled, and the use-after-free issue is also be fixed by this change since serdev is still opened when send to serdev.
Fixes: 272970be3dab ("Bluetooth: hci_qca: Fix driver shutdown on closed serdev") Cc: stable@vger.kernel.org Reported-by: Wren Turkal wt@penguintechs.org Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218726 Signed-off-by: Zijun Hu quic_zijuhu@quicinc.com Tested-by: Wren Turkal wt@penguintechs.org
drivers/bluetooth/hci_qca.c | 5 ++---
I don't think this is v1. Version your patches properly and provide changelog.
i sent it as v1 to start a new and clean discussion.
I asked already *two times*:
- On which kernel did you test it?
- On which hardware did you test it?
will provide such info within next commit message.
I am not interested in any replies like "I wrote something on bugzilla". I am really fed up with your elusive, time-wasting replies, so be specific here.
are there any other concerns about this patch itself?
Best regards, Krzysztof