Hello Greg,
Thank you for your responses. We’re in the process of learning the process and figuring out how to get the git send-mail out.
This patch aims for the kernel 6.12 and backports the changes for the mlx5 from 6.13 to it. We use the 1ce840c7a659aa53a31ef49f0271b4fd0dc10296 commit from upsteam to do it. We had to update the path within the patch to make the patch apply that’s the only change we made. We roll this out in our kernel and test it already.
I forgot to add my full name to it, we will fix Sujana's Name is correct. Please, I apologize for the puzzlement we might have caused.
Best regards, akendo
On 9/3/25 11:41 AM, Greg KH wrote:
On Wed, Sep 03, 2025 at 08:40:13AM +0000, Subramaniam, Sujana wrote:
From: SujanaSubr sujana.subramaniam@sap.com
[ Upstream commit 1ce840c7a659aa53a31ef49f0271b4fd0dc10296 ]
Currently, when firmware failure occurs during matcher disconnect flow, the error flow of the function reconnects the matcher back and returns an error, which continues running the calling function and eventually frees the matcher that is being disconnected. This leads to a case where we have a freed matcher on the matchers list, which in turn leads to use-after-free and eventual crash.
This patch fixes that by not trying to reconnect the matcher back when some FW command fails during disconnect.
Note that we're dealing here with FW error. We can't overcome this problem. This might lead to bad steering state (e.g. wrong connection between matchers), and will also lead to resource leakage, as it is the case with any other error handling during resource destruction.
However, the goal here is to allow the driver to continue and not crash the machine with use-after-free error.
Signed-off-by: Yevgeny Kliteynik kliteyn@nvidia.com Signed-off-by: Itamar Gozlan igozlan@nvidia.com Reviewed-by: Mark Bloch mbloch@nvidia.com Signed-off-by: Tariq Toukan tariqt@nvidia.com Link: https://patch.msgid.link/20250102181415.1477316-7-tariqt@nvidia.com Signed-off-by: Jakub Kicinski kuba@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org
Sasha didn't sign off on this original commit, did they?
Signed-off-by: Akendo akendo@akendo.eu
Real name?
Signed-off-by: SujanaSubr sujana.subramaniam@sap.com
Correct name?
What is this being sent for?
totally confused,
greg k-h