On Tue, Oct 08, 2024 at 10:31:02AM +0300, Yonatan Maman wrote:
From: Yonatan Maman Ymaman@Nvidia.com
When `nouveau_dmem_copy_one` is called, the following error occurs:
[272146.675156] nouveau 0000:06:00.0: fifo: PBDMA9: 00000004 [HCE_PRIV] ch 1 00000300 00003386
This indicates that a copy push command triggered a Host Copy Engine Privileged error on channel 1 (Copy Engine channel). To address this issue, modify the Copy Engine channel to allow privileged push commands
Fixes: 6de125383a5c ("drm/nouveau/fifo: expose runlist topology info on all chipsets") Signed-off-by: Yonatan Maman Ymaman@Nvidia.com Signed-off-by: Gal Shalom GalShalom@Nvidia.com Co-developed-by: Gal Shalom GalShalom@Nvidia.com
'Co-developed-by' must be immediately followed by the corresponding 'Signed-off-by'.
This is just a nit, but it indicates you didn't run ./scripts/checkpatch.pl, did you?
Reviewed-by: Ben Skeggs bskeggs@nvidia.com
drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index a58c31089613..0a75ce4c5021 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -356,7 +356,7 @@ nouveau_accel_ce_init(struct nouveau_drm *drm) return; }
- ret = nouveau_channel_new(drm, device, false, runm, NvDmaFB, NvDmaTT, &drm->cechan);
- ret = nouveau_channel_new(drm, device, true, runm, NvDmaFB, NvDmaTT, &drm->cechan);
This patch does not apply, it seems like it is based on some old or OOT version of the code.
Please make sure to rebase and test your patches against upstream code if you're submitting patches upstream.
if (ret) NV_ERROR(drm, "failed to create ce channel, %d\n", ret); } -- 2.34.1