Re: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

On Mon, Oct 14, 2024 at 10:56:35AM +0200, Javier Carrasco wrote:

This series refactors some useless goto instructions as a preparation for the fix of a missing of_node_put() by means of the cleanup attribute.

Signed-off-by: Javier Carrasco javier.carrasco.cruz@gmail.com

Changes in v2:

• Refactor vchiq_probe() to remove goto instructions.
• Declare and initialize the node right before its first usage.
• Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@g...

Thanks!

Reviewed-by: Dan Carpenter dan.carpenter@linaro.org

regards, dan carpenter