17 Jan
2020
17 Jan
'20
3:02 p.m.
On Fri, Jan 17, 2020 at 03:35:26PM +0100, Johan Hovold wrote:
Check for NULL port data in the modem- and line-status handlers to avoid dereferencing a NULL pointer in the unlikely case where a port device isn't bound to a driver (e.g. after an allocation failure on port probe).
Note that the other (stubbed) event handlers qt2_process_xmit_empty() and qt2_process_flush() would need similar sanity checks in case they are ever implemented.
Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver") Cc: stable stable@vger.kernel.org # 3.5 Signed-off-by: Johan Hovold johan@kernel.org
v2
- move sanity checks to where the actual dereferences take place
- drop sanity checks from the stubbed event handlers
Looks good, thanks for the rewrite:
Reviewed-by: Greg Kroah-Hartman gregkh@linuxfoundation.org