Hi!
commit 371a3bc79c11b707d7a1b7a2c938dc3cc042fffb upstream.
The function cpu_power_to_freq is used to find a frequency and set the cooling device to consume at most the power to be converted. For example, if the power to be converted is 80mW, and the em table is as follow. struct em_cap_state table[] = { /* KHz mW */ { 1008000, 36, 0 }, { 1200000, 49, 0 }, { 1296000, 59, 0 }, { 1416000, 72, 0 }, { 1512000, 86, 0 }, }; The target frequency should be 1416000KHz, not 1512000KHz.
...
Something is very wrong here, if table is sorted like described in the changelog, it will always break at i==0 or i==1... not working at all in the old or the new version.
As I understand from the other email you sent, this works fine now. Right ?
Yes, I believe the code is okay now.
OTOH the changelog is extremely confusing, because code would not work on the table presented there as an example.
Best regards, Pavel