3.16.61-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Dan Carpenter dan.carpenter@oracle.com
commit 5fc853cc01c68f84984ecc2d5fd777ecad78240f upstream.
We accidentally left out the error handling for kstrtoul().
Fixes: a520030e326a ("qlcnic: Implement flash sysfs callback for 83xx adapter") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com Signed-off-by: David S. Miller davem@davemloft.net Signed-off-by: Ben Hutchings ben@decadent.org.uk --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c @@ -1122,6 +1122,8 @@ static ssize_t qlcnic_83xx_sysfs_flash_w return QL_STATUS_INVALID_PARAM;
ret = kstrtoul(buf, 16, &data); + if (ret) + return ret;
switch (data) { case QLC_83XX_FLASH_SECTOR_ERASE_CMD: