On 07.10.2025 11:43, Johan Hovold wrote:
Make sure to drop the reference taken to the iommu platform device when looking up its driver data during of_xlate().
Note that commit 1a26044954a6 ("iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate()") fixed the leak in a couple of error paths, but the reference is still leaking on success.
Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices from device tree") Cc: stable@vger.kernel.org # 4.2: 1a26044954a6 Cc: Marek Szyprowski m.szyprowski@samsung.com Cc: Yu Kuai yukuai3@huawei.com Acked-by: Robin Murphy robin.murphy@arm.com Signed-off-by: Johan Hovold johan@kernel.org
Acked-by: Marek Szyprowski m.szyprowski@samsung.com
drivers/iommu/exynos-iommu.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index b6edd178fe25..ce9e935cb84c 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1446,17 +1446,14 @@ static int exynos_iommu_of_xlate(struct device *dev, return -ENODEV; data = platform_get_drvdata(sysmmu);
- if (!data) {
put_device(&sysmmu->dev);
- put_device(&sysmmu->dev);
- if (!data) return -ENODEV;
- }
if (!owner) { owner = kzalloc(sizeof(*owner), GFP_KERNEL);
if (!owner) {put_device(&sysmmu->dev);
if (!owner) return -ENOMEM;
}INIT_LIST_HEAD(&owner->controllers); mutex_init(&owner->rpm_lock);
Best regards