On Mon, Oct 28, 2024 at 1:50 PM Johan Hovold johan+linaro@kernel.org wrote:
Add the missing newline after entries for recently removed gpio chips so that the chip sections are separated by a newline as intended.
Fixes: e348544f7994 ("gpio: protect the list of GPIO devices with SRCU") Cc: stable@vger.kernel.org # 6.9 Cc: Bartosz Golaszewski bartosz.golaszewski@linaro.org Signed-off-by: Johan Hovold johan+linaro@kernel.org
drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index e27488a90bc9..2b02655abb56 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -4971,7 +4971,7 @@ static int gpiolib_seq_show(struct seq_file *s, void *v)
gc = srcu_dereference(gdev->chip, &gdev->srcu); if (!gc) {
seq_printf(s, "%s%s: (dangling chip)",
seq_printf(s, "%s%s: (dangling chip)\n", priv->newline ? "\n" : "", dev_name(&gdev->dev)); return 0;-- 2.45.2
But with this change we go from an incorrect:
# cat /sys/kernel/debug/gpio gpiochip0: (dangling chip) gpiochip1: (dangling chip) gpiochip2: (dangling chip)root@qemux86-64:~#
to still incorrect:
# cat /sys/kernel/debug/gpio gpiochip0: (dangling chip)
gpiochip1: (dangling chip)
gpiochip2: (dangling chip)
Bart