Re: [PATCH v5 0/2] Return EADDRNOTAVAIL when func matches several symbols during kprobe creation

Hi!

Le mercredi 18 octobre 2023, 20:00:42 EEST Steven Rostedt a écrit :

On Wed, 18 Oct 2023 17:40:28 +0300

Francis Laniel flaniel@linux.microsoft.com wrote:

...

Changes since: v1:

• Use EADDRNOTAVAIL instead of adding a new error code.
• Correct also this behavior for sysfs kprobe.

v2:

• Count the number of symbols corresponding to function name and return

EADDRNOTAVAIL if higher than 1.

• Return ENOENT if above count is 0, as it would be returned later by

while registering the kprobe. v3:

• Check symbol does not contain ':' before testing its uniqueness.
• Add a selftest to check this is not possible to install a kprobe for a

non unique symbol. v5:

• No changes, just add linux-stable as recipient.

So why is this adding stable? (and as Greg's form letter states, that's not how you do that)

Oops! Really sorry for this, I will correct everything for the next version!

I don't see this as a fix but a new feature.

You mean I should add a "Fix:" in the commit description?

-- Steve

Best regards.