7 Feb
2019
7 Feb
'19
9:39 a.m.
Hi Dan,
On 2/7/2019 1:42 PM, Dan Carpenter wrote:
This patch was very confusing to review...
Apologies for the confusion.
From a process perspective, you really should fold patches 1 and 2 together. Otherwise we're re-introducing a bug.
Patch 1 and Patch 2 both are required if commit 0e490657c721 ("staging: wilc1000: Fix problem with wrong vif index") is applied else Patch 2 is enough for complete fix. For the above reason, I have divided the fixes into 2 patches. Please suggest, if I should go ahead and submit this in a single patch. Should I put 2 'Fixes:' tag in that merge commit or only 0e490657c721 commit is enough.
Regards, Ajay