Re: [PATCH 1/5] usb: misc: onboard_usb_dev: fix support for Cypress HX3 hubs

On Wed, Mar 26, 2025 at 05:22:56PM +0100, Lukasz Czechowski wrote:

diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h index 317b3eb99c02..17696f7c5e43 100644 --- a/drivers/usb/misc/onboard_usb_dev.h +++ b/drivers/usb/misc/onboard_usb_dev.h @@ -104,8 +104,14 @@ static const struct of_device_id onboard_dev_match[] = { { .compatible = "usb451,8027", .data = &ti_tusb8020b_data, }, { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, { .compatible = "usb451,8142", .data = &ti_tusb8041_data, },

• { .compatible = "usb4b4,6500", .data = &cypress_hx3_data, },
• { .compatible = "usb4b4,6502", .data = &cypress_hx3_data, },
• { .compatible = "usb4b4,6503", .data = &cypress_hx3_data, }, { .compatible = "usb4b4,6504", .data = &cypress_hx3_data, }, { .compatible = "usb4b4,6506", .data = &cypress_hx3_data, },
• { .compatible = "usb4b4,6507", .data = &cypress_hx3_data, },
• { .compatible = "usb4b4,6508", .data = &cypress_hx3_data, },

Why are you adding so many entries? Same entry is a strong sign these are compatible.

Best regards, Krzysztof