On Thu, 2020-01-09 at 13:12 +0100, Salvatore Bonaccorso wrote:
Hi Ben,
On Wed, Jan 08, 2020 at 07:44:00PM +0000, Ben Hutchings wrote:
3.16.81-rc1 review patch. If anyone has any objections, please let me know.
From: Ganapathi Bhat gbhat@marvell.com
commit 3d94a4a8373bf5f45cf5f939e88b8354dbf2311b upstream.
[...]
Brian Norris noted that this commit has unbalanced locking and submitted a followup as per:
https://lkml.kernel.org/linux-wireless/20200106224212.189763-1-briannorris@c... https://patchwork.kernel.org/patch/11320227/
Right, but is the new behaviour (possible wrong preemption count) actually worse than the old behaviour (possible heap buffer overflow)?
I think we are better off applying this now and adding that fix once it's upstream.
Ben.