Re: [PATCH v3 2/6] ata: libata-scsi: Do not overwrite valid sense data when CK_COND=1

On Thu, Jun 27, 2024 at 04:14:09PM +0200, Niklas Cassel wrote:

The only tricky case is if we should set CHECK_CONDITION in case c) or not. All other cases seems quite clear by looking at the SAT spec.

I think we should set CHECK_CONDITION in case c), even if SK+ASCQ+ASC is not "ATA PASS-THROUGH INFORMATION AVAILABLE".

That way we at least align CK_COND with CHECK_CONDITION, which is most likely what the user (and spec writers) expect.

Kind regards, Niklas