25 Oct
2021
25 Oct
'21
3:51 p.m.
On Mon, Oct 25, 2021 at 08:41:36AM -0700, Joe Perches wrote:
On Mon, 2021-10-25 at 10:06 -0500, Larry Finger wrote:
On 10/25/21 07:09, Johan Hovold wrote:
USB control-message timeouts are specified in milliseconds and should specifically not vary with CONFIG_HZ.
There appears to be more than a few of these in the kernel.
$ cat usb_hz.cocci @@ expression e; @@
- usb_control_msg(..., HZ * e)
@@ expression e; @@
- usb_control_msg(..., HZ / e)
@@ @@
- usb_control_msg(..., HZ)
$ spatch --very-quiet -U 0 -sp-file usb_hz.cocci . warning: line 4: should HZ be a metavariable? warning: line 9: should HZ be a metavariable? warning: line 13: should HZ be a metavariable? 50 files match
Look at the lists, he's sent a bunch of fixes for this today to all the subsystems...
greg k-h