From: Zenm Chen zenmchen@gmail.com
[ Upstream commit 17002412a82feb21be040bd5577789049dfeebe2 ]
Add USB ID 2001:3327 for D-Link AX18U rev. A1 which is a RTL8832BU-based Wi-Fi adapter.
Link: https://github.com/morrownr/rtw89/pull/17 Signed-off-by: Zenm Chen zenmchen@gmail.com Acked-by: Ping-Ke Shih pkshih@realtek.com Signed-off-by: Ping-Ke Shih pkshih@realtek.com Link: https://patch.msgid.link/20250903223100.3031-1-zenmchen@gmail.com Signed-off-by: Sasha Levin sashal@kernel.org ---
LLM Generated explanations, may be completely bogus:
YES
- What changed - Adds a new USB device ID entry for D-Link AX18U rev. A1 (vendor 0x2001, product 0x3327) to the rtw8852bu driver’s ID table so the device binds to this driver: drivers/net/wireless/realtek/rtw89/rtw8852bu.c:33–34. - The entry maps to `rtw89_8852bu_info`, identical to existing 8852BU- based devices in the same table: drivers/net/wireless/realtek/rtw89/rtw8852bu.c:10–14,16–44.
- Effect and correctness - With this ID present, usbcore will match the device and call the driver’s probe with the associated `driver_info`. The probe uses `id->driver_info` to select the chip info and bring the device up: drivers/net/wireless/realtek/rtw89/usb.c:940–945, and registers the hw stack via the standard rtw89 USB path: drivers/net/wireless/realtek/rtw89/usb.c:956–999. - The new entry uses the same matching macro and interface class triplet (`USB_DEVICE_AND_INTERFACE_INFO(..., 0xff, 0xff, 0xff)`) as the existing entries, minimizing false positives and aligning with vendor-specific Realtek interfaces: drivers/net/wireless/realtek/rtw89/rtw8852bu.c:16–44.
- Scope and risk - Purely additive, one-line functional change confined to a device ID table; no logic, control flow, or data structure changes. - No architectural impact; does not touch critical subsystems beyond enabling auto-binding for this ID. - Low regression risk for existing users; only affects systems that plug in this specific device. If the device is indeed RTL8832BU/8852B-family (as stated in the commit) the mapping to `rtw89_8852bu_info` is correct and consistent with the rest of the table.
- Stable backport criteria - Fixes a real-world usability gap: without this ID, the adapter is not recognized and cannot be used, which is treated as a practical bug for end users. - Minimal patch size and risk; typical “add device ID” enablement often accepted for stable. - No new features or behavioral changes to existing devices.
Recommendation: Backport to any stable trees that already contain the rtw89 USB support and `rtw8852bu.c`. This provides immediate hardware enablement with negligible risk.
drivers/net/wireless/realtek/rtw89/rtw8852bu.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852bu.c b/drivers/net/wireless/realtek/rtw89/rtw8852bu.c index b315cb997758a..0694272f7ffae 100644 --- a/drivers/net/wireless/realtek/rtw89/rtw8852bu.c +++ b/drivers/net/wireless/realtek/rtw89/rtw8852bu.c @@ -30,6 +30,8 @@ static const struct usb_device_id rtw_8852bu_id_table[] = { .driver_info = (kernel_ulong_t)&rtw89_8852bu_info }, { USB_DEVICE_AND_INTERFACE_INFO(0x0db0, 0x6931, 0xff, 0xff, 0xff), .driver_info = (kernel_ulong_t)&rtw89_8852bu_info }, + { USB_DEVICE_AND_INTERFACE_INFO(0x2001, 0x3327, 0xff, 0xff, 0xff), + .driver_info = (kernel_ulong_t)&rtw89_8852bu_info }, { USB_DEVICE_AND_INTERFACE_INFO(0x3574, 0x6121, 0xff, 0xff, 0xff), .driver_info = (kernel_ulong_t)&rtw89_8852bu_info }, { USB_DEVICE_AND_INTERFACE_INFO(0x35bc, 0x0100, 0xff, 0xff, 0xff),