From: Takashi Iwai tiwai@suse.de
[ Upstream commit 41c66461cb2e8d3934a5395f27e572ebe63696b4 ]
ASUS UM5606* models use the quirk to set up the bass speakers, but it missed the mic-mute LED configuration. Other similar models have the AMD ACP dmic, and the mic-mute is set up for that, but those models don't have AMD ACP but rather built-in mics of Realtek codec, hence the Realtek driver should set it up, instead.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=220125 Link: https://patch.msgid.link/20250623151841.28810-1-tiwai@suse.de Signed-off-by: Takashi Iwai tiwai@suse.de Signed-off-by: Sasha Levin sashal@kernel.org ---
**YES**
This commit should be backported to stable kernel trees. Here's my extensive analysis:
## Code Change Analysis
The commit adds a single line to the `alc294_fixup_bass_speaker_15` function: ```c snd_hda_gen_add_micmute_led_cdev(codec, NULL); ```
This is a minimal, targeted fix that adds mic-mute LED support to an existing quirk used by ASUS UM5606 models.
## Reasons for Backporting
1. **Fixes Missing Hardware Functionality**: The commit addresses a genuine bug where the mic-mute LED hardware exists on ASUS UM5606* models but wasn't being initialized by the driver. Users expect this LED to work as it does on other laptops.
2. **User-Reported Issue**: The commit references bug reports (bugzilla.kernel.org #220125), indicating real users are affected by this missing functionality.
3. **Small and Contained Fix**: The change is a single line addition that only affects the specific quirk for ASUS UM5606 models. It has zero impact on other hardware.
4. **Follows Established Patterns**: All five similar commits provided as reference (which were backported) fix similar hardware-specific audio/LED issues: - They add or fix quirks for specific laptop models - They address missing LED functionality - They are minimal, targeted fixes
5. **No Architectural Changes**: The fix uses existing infrastructure (`snd_hda_gen_add_micmute_led_cdev`) and doesn't introduce any new APIs or change existing behavior.
6. **Low Risk of Regression**: Since this only affects the `ALC294_FIXUP_BASS_SPEAKER_15` fixup (used exclusively by ASUS UM5606WA and UM5606KA models), there's virtually no risk of breaking other systems.
## Comparison to Similar Backported Commits
Looking at the reference commits marked "YES" for backporting: - "ALSA: hda/realtek - Enable Speaker for ASUS UX563" - adds missing speaker functionality - "ALSA: hda/realtek - add supported Mic Mute LED for Lenovo platform" - adds mic-mute LED support - "ALSA: hda/realtek: Enable mute/micmute LEDs and speaker support for HP Laptops" - adds LED support
This commit follows the exact same pattern: fixing missing hardware functionality (mic-mute LED) for specific laptop models.
## Note on Missing Cc: stable
While this commit doesn't include "Cc: stable@vger.kernel.org" in its message (unlike the reference commits), this doesn't disqualify it from backporting. The commit clearly meets the stable tree criteria as an important bugfix with minimal risk.
The investigation confirms this is filling a genuine gap - ASUS UM5606 models currently have no LED support despite having the hardware, and this one-line fix enables the mic-mute LED functionality users expect.
sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 02a424b7a9920..16f361b2877a7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6609,6 +6609,7 @@ static void alc294_fixup_bass_speaker_15(struct hda_codec *codec, if (action == HDA_FIXUP_ACT_PRE_PROBE) { static const hda_nid_t conn[] = { 0x02, 0x03 }; snd_hda_override_conn_list(codec, 0x15, ARRAY_SIZE(conn), conn); + snd_hda_gen_add_micmute_led_cdev(codec, NULL); } }