Re: [PATCH] tools/nolibc: include arch.h from string.h

Hi Thomas,

On Thu, Jul 25, 2024 at 06:54:18PM +0200, Thomas Weißschuh wrote:

string.h tests for the macros NOLIBC_ARCH_HAS_$FUNC to use the architecture-optimized function variants. However if string.h is included before arch.h header than that check

^^^^ then

does not work, leading to duplicate function definitions.

Fixes: 553845eebd60 ("tools/nolibc: x86-64: Use `rep movsb` for `memcpy()` and `memmove()`") Fixes: 12108aa8c1a1 ("tools/nolibc: x86-64: Use `rep stosb` for `memset()`") Cc: stable@vger.kernel.org Signed-off-by: Thomas Weißschuh linux@weissschuh.net

Good catch!

Acked-by: Willy Tarreau w@1wt.eu

Thanks, Willy