-----Original Message----- From: dri-devel dri-devel-bounces@lists.freedesktop.org On Behalf Of Thomas Zimmermann Sent: Monday, June 12, 2023 10:08 AM To: daniel@ffwll.ch; javierm@redhat.com; sam@ravnborg.org; deller@gmx.de; geert+renesas@glider.be; lee@kernel.org; daniel.thompson@linaro.org; jingoohan1@gmail.com; dan.carpenter@linaro.org; Ruhl, Michael J michael.j.ruhl@intel.com Cc: linux-fbdev@vger.kernel.org; Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com; linux-sh@vger.kernel.org; linux-staging@lists.linux.dev; linux-kernel@vger.kernel.org; dri- devel@lists.freedesktop.org; stable@vger.kernel.org; Thomas Zimmermann tzimmermann@suse.de; linux-omap@vger.kernel.org Subject: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device
Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device.
Fixes a bug in the backlight driver and prepares fbdev for making struct fb_info.dev optional.
v2:
- move renames into separate patch (Javier, Sam, Michael)
Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver") Signed-off-by: Thomas Zimmermann tzimmermann@suse.de Cc: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Cc: Lee Jones lee@kernel.org Cc: Daniel Thompson daniel.thompson@linaro.org Cc: Jingoo Han jingoohan1@gmail.com Cc: dri-devel@lists.freedesktop.org Cc: stable@vger.kernel.org # v3.12+ Reviewed-by: Javier Martinez Canillas javierm@redhat.com
drivers/video/backlight/bd6107.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/bd6107.c b/drivers/video/backlight/bd6107.c index f4db6c064635b..e3410444ea235 100644 --- a/drivers/video/backlight/bd6107.c +++ b/drivers/video/backlight/bd6107.c @@ -104,7 +104,7 @@ static int bd6107_backlight_check_fb(struct backlight_device *backlight, { struct bd6107 *bd = bl_get_data(backlight);
- return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->dev;
- return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->device;
Thomas,
Looking at the fb.h file I see:
struct device *device; /* This is the parent */ struct device *dev; /* This is this fb device */
Is this documentation "correct"? If so, how does that match what you are doing here?
Thanks,
M
}
static const struct backlight_ops bd6107_backlight_ops = {
2.41.0