On 06/12/2024 16:32, Krzysztof Kozlowski wrote:
The address space in ADSP PAS (Peripheral Authentication Service) remoteproc node should point to the QDSP PUB address space (QDSP6...SS_PUB): 0x0680_0000 with length of 0x10000.
0x3000_0000, value used so far, is the main region of CDSP. Downstream DTS uses 0x0300_0000, which is oddly similar to 0x3000_0000, yet quite different and points to unused area.
Correct the base address and length, which also moves the node to different place to keep things sorted by unit address. The diff looks big, but only the unit address and "reg" property were changed. This should have no functional impact on Linux users, because PAS loader does not use this address space at all.
Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
arch/arm64/boot/dts/qcom/sm8650.dtsi | 296 +++++++++++++++++------------------ 1 file changed, 148 insertions(+), 148 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 25e47505adcb790d09f1d2726386438487255824..95ec82bce3162bce4a3da6122a41fee37118740e 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -2904,6 +2904,154 @@ IPCC_MPROC_SIGNAL_GLINK_QMP }; };
remoteproc_adsp: remoteproc@6800000 {compatible = "qcom,sm8650-adsp-pas";reg = <0x0 0x06800000 0x0 0x10000>;interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>;interrupt-names = "wdog","fatal","ready","handover","stop-ack";clocks = <&rpmhcc RPMH_CXO_CLK>;clock-names = "xo";interconnects = <&lpass_lpicx_noc MASTER_LPASS_PROC QCOM_ICC_TAG_ALWAYS&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;power-domains = <&rpmhpd RPMHPD_LCX>,<&rpmhpd RPMHPD_LMX>;power-domain-names = "lcx","lmx";memory-region = <&adspslpi_mem>, <&q6_adsp_dtb_mem>;qcom,qmp = <&aoss_qmp>;qcom,smem-states = <&smp2p_adsp_out 0>;qcom,smem-state-names = "stop";status = "disabled";remoteproc_adsp_glink: glink-edge {interrupts-extended = <&ipcc IPCC_CLIENT_LPASSIPCC_MPROC_SIGNAL_GLINK_QMPIRQ_TYPE_EDGE_RISING>;mboxes = <&ipcc IPCC_CLIENT_LPASSIPCC_MPROC_SIGNAL_GLINK_QMP>;qcom,remote-pid = <2>;label = "lpass";fastrpc {compatible = "qcom,fastrpc";qcom,glink-channels = "fastrpcglink-apps-dsp";label = "adsp";qcom,non-secure-domain;#address-cells = <1>;#size-cells = <0>;compute-cb@3 {compatible = "qcom,fastrpc-compute-cb";reg = <3>;iommus = <&apps_smmu 0x1003 0x80>,<&apps_smmu 0x1043 0x20>;dma-coherent;};compute-cb@4 {compatible = "qcom,fastrpc-compute-cb";reg = <4>;iommus = <&apps_smmu 0x1004 0x80>,<&apps_smmu 0x1044 0x20>;dma-coherent;};compute-cb@5 {compatible = "qcom,fastrpc-compute-cb";reg = <5>;iommus = <&apps_smmu 0x1005 0x80>,<&apps_smmu 0x1045 0x20>;dma-coherent;};compute-cb@6 {compatible = "qcom,fastrpc-compute-cb";reg = <6>;iommus = <&apps_smmu 0x1006 0x80>,<&apps_smmu 0x1046 0x20>;dma-coherent;};compute-cb@7 {compatible = "qcom,fastrpc-compute-cb";reg = <7>;iommus = <&apps_smmu 0x1007 0x40>,<&apps_smmu 0x1067 0x0>,<&apps_smmu 0x1087 0x0>;dma-coherent;};};gpr {compatible = "qcom,gpr";qcom,glink-channels = "adsp_apps";qcom,domain = <GPR_DOMAIN_ID_ADSP>;qcom,intents = <512 20>;#address-cells = <1>;#size-cells = <0>;q6apm: service@1 {compatible = "qcom,q6apm";reg = <GPR_APM_MODULE_IID>;#sound-dai-cells = <0>;qcom,protection-domain = "avs/audio","msm/adsp/audio_pd";q6apmbedai: bedais {compatible = "qcom,q6apm-lpass-dais";#sound-dai-cells = <1>;};q6apmdai: dais {compatible = "qcom,q6apm-dais";iommus = <&apps_smmu 0x1001 0x80>,<&apps_smmu 0x1061 0x0>;};};q6prm: service@2 {compatible = "qcom,q6prm";reg = <GPR_PRM_MODULE_IID>;qcom,protection-domain = "avs/audio","msm/adsp/audio_pd";q6prmcc: clock-controller {compatible = "qcom,q6prm-lpass-clocks";#clock-cells = <2>;};};};};};- lpass_wsa2macro: codec@6aa0000 { compatible = "qcom,sm8650-lpass-wsa-macro", "qcom,sm8550-lpass-wsa-macro"; reg = <0 0x06aa0000 0 0x1000>;
@@ -5322,154 +5470,6 @@ system-cache-controller@25000000 { interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; };
remoteproc_adsp: remoteproc@30000000 {compatible = "qcom,sm8650-adsp-pas";reg = <0 0x30000000 0 0x100>;interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,<&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>;interrupt-names = "wdog","fatal","ready","handover","stop-ack";clocks = <&rpmhcc RPMH_CXO_CLK>;clock-names = "xo";interconnects = <&lpass_lpicx_noc MASTER_LPASS_PROC QCOM_ICC_TAG_ALWAYS&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;power-domains = <&rpmhpd RPMHPD_LCX>,<&rpmhpd RPMHPD_LMX>;power-domain-names = "lcx","lmx";memory-region = <&adspslpi_mem>, <&q6_adsp_dtb_mem>;qcom,qmp = <&aoss_qmp>;qcom,smem-states = <&smp2p_adsp_out 0>;qcom,smem-state-names = "stop";status = "disabled";remoteproc_adsp_glink: glink-edge {interrupts-extended = <&ipcc IPCC_CLIENT_LPASSIPCC_MPROC_SIGNAL_GLINK_QMPIRQ_TYPE_EDGE_RISING>;mboxes = <&ipcc IPCC_CLIENT_LPASSIPCC_MPROC_SIGNAL_GLINK_QMP>;qcom,remote-pid = <2>;label = "lpass";fastrpc {compatible = "qcom,fastrpc";qcom,glink-channels = "fastrpcglink-apps-dsp";label = "adsp";qcom,non-secure-domain;#address-cells = <1>;#size-cells = <0>;compute-cb@3 {compatible = "qcom,fastrpc-compute-cb";reg = <3>;iommus = <&apps_smmu 0x1003 0x80>,<&apps_smmu 0x1043 0x20>;dma-coherent;};compute-cb@4 {compatible = "qcom,fastrpc-compute-cb";reg = <4>;iommus = <&apps_smmu 0x1004 0x80>,<&apps_smmu 0x1044 0x20>;dma-coherent;};compute-cb@5 {compatible = "qcom,fastrpc-compute-cb";reg = <5>;iommus = <&apps_smmu 0x1005 0x80>,<&apps_smmu 0x1045 0x20>;dma-coherent;};compute-cb@6 {compatible = "qcom,fastrpc-compute-cb";reg = <6>;iommus = <&apps_smmu 0x1006 0x80>,<&apps_smmu 0x1046 0x20>;dma-coherent;};compute-cb@7 {compatible = "qcom,fastrpc-compute-cb";reg = <7>;iommus = <&apps_smmu 0x1007 0x40>,<&apps_smmu 0x1067 0x0>,<&apps_smmu 0x1087 0x0>;dma-coherent;};};gpr {compatible = "qcom,gpr";qcom,glink-channels = "adsp_apps";qcom,domain = <GPR_DOMAIN_ID_ADSP>;qcom,intents = <512 20>;#address-cells = <1>;#size-cells = <0>;q6apm: service@1 {compatible = "qcom,q6apm";reg = <GPR_APM_MODULE_IID>;#sound-dai-cells = <0>;qcom,protection-domain = "avs/audio","msm/adsp/audio_pd";q6apmbedai: bedais {compatible = "qcom,q6apm-lpass-dais";#sound-dai-cells = <1>;};q6apmdai: dais {compatible = "qcom,q6apm-dais";iommus = <&apps_smmu 0x1001 0x80>,<&apps_smmu 0x1061 0x0>;};};q6prm: service@2 {compatible = "qcom,q6prm";reg = <GPR_PRM_MODULE_IID>;qcom,protection-domain = "avs/audio","msm/adsp/audio_pd";q6prmcc: clock-controller {compatible = "qcom,q6prm-lpass-clocks";#clock-cells = <2>;};};};};};- nsp_noc: interconnect@320c0000 { compatible = "qcom,sm8650-nsp-noc"; reg = <0 0x320c0000 0 0xf080>;
Reviewed-by: Neil Armstrong neil.armstrong@linaro.org