Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader.

On Di, 2018-12-18 at 13:38 +0100, Johan Hovold wrote:

On

...

@@ -1655,7 +1662,10 @@ static int acm_pre_reset(struct usb_interface *intf) .driver_info = NO_UNION_NORMAL, /* has no union descriptor */ }, { USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */

• .driver_info = NO_UNION_NORMAL, /* has no union descriptor */

• .driver_info = DISABLE_ECHO, /* DISABLE ECHO in termios flag */

I just noticed that you remove the NO_UNION_NORMAL here, which looks wrong and definitely requires a motivation.

Thanks, Johan

Hi,

thank you and thank you Johan. Unfortunately I cannot take this until the issue with the removed quirk is clarified.

Regards Oliver